Skip to content

Fix up BG Parsing in Events, PP Calculation & Add in simple hit judgements#102

Closed
kpei wants to merge 17 commits into
llllllllll:masterfrom
kpei:benis
Closed

Fix up BG Parsing in Events, PP Calculation & Add in simple hit judgements#102
kpei wants to merge 17 commits into
llllllllll:masterfrom
kpei:benis

Conversation

@kpei
Copy link
Copy Markdown

@kpei kpei commented May 12, 2022

This is a change made on top of #69

Fixed bg parsing if no offset was specified
Added back some basic class methods for beatmap because performance_points method was erroring
Simple hit judgement stuff mostly so I can calculate UR. Don't have to implement it, it's just a wrapper I made around Replay.hits method.

Comment thread slider/beatmap.py
@Liam-DeVoe
Copy link
Copy Markdown
Collaborator

Liam-DeVoe commented May 20, 2022

I'm going to close this in favor of #69 and #103 (bg without offset parsing is fixed in the former). The addition of a judgment class is definitely useful, but it's with too many other changes in this PR. Feel free to create a new PR with just the judgment class changes if you want.

@Liam-DeVoe Liam-DeVoe closed this May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants