Fix up BG Parsing in Events, PP Calculation & Add in simple hit judgements#102
Closed
kpei wants to merge 17 commits into
Closed
Fix up BG Parsing in Events, PP Calculation & Add in simple hit judgements#102kpei wants to merge 17 commits into
kpei wants to merge 17 commits into
Conversation
Liam-DeVoe
reviewed
May 18, 2022
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a change made on top of #69
Fixed bg parsing if no offset was specified
Added back some basic class methods for beatmap because
performance_pointsmethod was erroringSimple hit judgement stuff mostly so I can calculate UR. Don't have to implement it, it's just a wrapper I made around
Replay.hitsmethod.