add missing DE translations - #2285
Conversation
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
CrazyWolf13
left a comment
CrazyWolf13
left a comment
There was a problem hiding this comment.
A couple of comments, otherwise lgtm.
| "gpu-memory": "Speicher", | ||
| "gpu-temperature": "Temperatur", | ||
| "gpu-fan-speed": "Lüfter", | ||
| "gpu-none": "Keine GPU erkannt" |
There was a problem hiding this comment.
Keine Grafikkarte erkannt?
There was a problem hiding this comment.
"gpu-none": "No GPU detected" means no graphic processing unit. `Grafikkarte` would be wrong translation, as it should be names "No graphics card detected" then
| "system-load-desc": "Prozesse in der Warteschlange, Durchschnitt aller Kerne" | ||
| "system-load-desc": "Prozesse in der Warteschlange, Durchschnitt aller Kerne", | ||
| "gpu-usage": "Auslastung", | ||
| "gpu-memory": "Speicher", |
There was a problem hiding this comment.
VRAM oder Grafikspeicher?
There was a problem hiding this comment.
"gpu-memory": "Memory",is the original string. I think "Speicher" is generic enough, like in english version
| "disk-io-write": "Schreiben", | ||
| "system-load-desc": "Prozesse in der Warteschlange, Durchschnitt aller Kerne" | ||
| "system-load-desc": "Prozesse in der Warteschlange, Durchschnitt aller Kerne", | ||
| "gpu-usage": "Auslastung", |
There was a problem hiding this comment.
Grafikauslastung?
Or is this like already in a GPU section and therefore does not need the gpu (grafikkarten) prerix?
There was a problem hiding this comment.
"gpu-usage": "Usage", is the original english. so i would not like to add more context in german than in english
| "no-data": "keine Daten konfiguriert", | ||
| "no-items-section": "Noch keine Elemente zum Anzeigen" | ||
| "no-items-section": "Noch keine Elemente zum Anzeigen", | ||
| "session-expired-line1": "Deine Sitzung ist abgelaufen", |
There was a problem hiding this comment.
Hier per Du weiter unten per Sie?
There was a problem hiding this comment.
aye, sorry you are right. Should be "Ihre Sitzung ist abgelaufen"
There was a problem hiding this comment.
added fix as commit number two
|
Thank you @CrazyWolf13 and @vmario89 🩵 I'm happy to merge, if this is good with you :) Here's the en values for the new german strings, just to clarify things: "home.session-expired-line1": "Your session has expired"
"home.session-expired-line2": "Re-authenticate to access your dashboard"
"home.sign-in-again": "Sign In Again"
"search.enter-to-launch-first": "Press enter to launch first match"
"login.authenticated-redirecting": "Authenticated, Redirecting..."
"interactive-editor.edit-section.edit-tooltip-basic": "Click to Edit"
"interactive-editor.edit-section.missing-name-err": "A section name is required"
"interactive-editor.edit-section.duplicate-name-err": "A section named '{name}' already exists"
"widgets.github-profile.repos": "Repos"
"widgets.github-profile.followers": "Followers"
"widgets.github-profile.following": "Following"
"widgets.github-profile.stars": "Stars"
"widgets.github-profile.forks": "Forks"
"widgets.github-profile.issues": "Issues"
"widgets.glances.gpu-usage": "Usage"
"widgets.glances.gpu-memory": "Memory"
"widgets.glances.gpu-temperature": "Temp"
"widgets.glances.gpu-fan-speed": "Fan"
"widgets.glances.gpu-none": "No GPU detected" |
fix person
|
great, looks good to me then 🚀 Wasn't sure how detailed en.json was, so thanks for quickly pasting them, as I'm currently only available from mobile. |
3 participants
This adds some strings which were not present in the latest de.json and it adds the open request of #2279 (comment)