fix: serialize local ASR model access#611
Draft
LauraGPT wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AutoModel.generate()calls on that shared modelRoot cause
Each WebSocket handler sends blocking ASR work to the default thread pool, while
all handlers share the module-level
_sensevoice_model. The previous GIL-basedassumption did not protect the check-then-initialize sequence, so concurrent
first requests could construct multiple models.
The shared FunASR
AutoModelis also stateful duringgenerate(): it resets andupdates runtime configuration dictionaries for the model and VAD pipeline.
Allowing two executor threads to enter the same instance concurrently can race
those mutations and create unnecessary GPU memory pressure.
Both locks are acquired inside executor workers, so the aiohttp event loop
remains non-blocking. Concurrent requests queue only at the shared model
boundary.
Validation
python -m unittest discover -s tests -p "test_*.py" -vpython -m compileall -q server/asr_server.py tests/test_asr_server.pygit diff --check