feat: Add AT-SPI accessible names for UI components - #208
Draft
re2zero wants to merge 1 commit into
Draft
Conversation
Add setAccessibleName() calls to all major UI components including main window, dialogs, and widgets to improve accessibility support for AT-SPI testing frameworks. Key changes: - DFontMgrMainWindow: Add accessible names for title bar, sidebar, preview list, state bar, search, and slider widgets - DFontBaseDialog: Add accessible names for title bar, logo icon, close button, and title text - DFontInfoDialog: Add accessible names for content frame, file name label, and scroll area - DFDeleteDialog/DFHandleTTCDialog: Add accessible names for dialog and button widgets - DFInstallNormalWindow: Add accessible names for progress labels and progress bar - DFQuickInstallWindow: Add accessible names for title, font type, preview, state label, and action button - DFInstallErrorDialog: Add accessible names for dialog and list view - DFontSpinnerWidget: Add accessible names for spinner and label - tests/at-spi/expected_names.yaml: New file documenting all AT-SPI accessible names for verification Update copyright years to 2026 for modified files.
Reviewer's GuideAdds AT-SPI accessible names to major deepin-font-manager UI components and introduces a YAML expectations file to validate them, alongside copyright year updates. Flow diagram for AT-SPI accessible name validation using expected_names.yamlflowchart LR
TestRunner[AT-SPI test runner] -->|loads| ExpectedNames[expected_names.yaml]
TestRunner -->|launches| FontManagerApp[deepin-font-manager]
FontManagerApp -->|creates| UIComponents[UI widgets with setAccessibleName]
AT_SPI[AT-SPI framework] -->|queries names from| UIComponents
TestRunner -->|compares queried names to| ExpectedNames
ExpectedNames -->|pass/fail result| TestRunner
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Skipping CI for Draft Pull Request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add setAccessibleName() calls to all major UI components in deepin-font-manager to improve accessibility support for AT-SPI testing frameworks.
Changes
Copyright years updated to 2026 for modified files.
Verification
Summary by Sourcery
Add accessible names across major deepin-font-manager windows and dialogs to improve AT-SPI-based accessibility and automated testing.
Enhancements:
Tests:
Chores: