Skip to content

REGRESSION TESTING for next Dasharo+Heads: v560tu/v540tu dasharo tag 1.0.1-rc3 / nv4x_adl 1.8.0-rc4 (ns50 partial, todo: remove changes) #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tlaurion wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

REGRESSION TESTING for next Dasharo+Heads: v560tu/v540tu dasharo tag 1.0.1-rc3 / nv4x_adl 1.8.0-rc4 (ns50 partial, todo: remove changes) #2039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0d4c8ac
Makefile: Auto-clean board build directories when coreboot canary cha…
tlaurion Dec 4, 2025
66621cd
modules/coreboot + config/coreboot-novacustom* config/coreboot-nitrop…
tlaurion Dec 4, 2025
d9d05fd
config/coreboot-novacustom* : put in defconfig, review needed changes…
tlaurion Jan 4, 2026
a7d59a5
config/coreboot-novacustom* : put in oldconfig, no manual change
tlaurion Jan 4, 2026
c007f83
config/coreboot-novacustom* : verify changes in oldconfig, first pass…
tlaurion Jan 4, 2026
9fbf6f8
config/coreboot-novacustom* : verify changes in oldconfig: bug in def…
tlaurion Jan 4, 2026
2c165ad
config/coreboot-novacustom* : verify changes in oldconfig: bug in def…
tlaurion Jan 4, 2026
a4eabcf
config/coreboot-novacustom* : verify changes in oldconfig: brick v560…
tlaurion Jan 4, 2026
7003f89
config/coreboot-novacustom* : verify changes in oldconfig: CMOS_ALTCE…
tlaurion Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,10 @@ define define_module =
git -C "$(build)/$($1_base_dir)" submodule sync && \
echo "INFO: Updating submodules (init and checkout)" && \
git -C "$(build)/$($1_base_dir)" submodule update --init --checkout && \
echo "INFO: Cleaning board-specific build directories to prevent stale artifacts" && \
rm -rf "$(build)/$(BOARD)" "$(build)/$($1_base_dir)/$(BOARD)" && \
echo "INFO: Recreating board directories" && \
mkdir -p "$(build)/$(BOARD)" "$(build)/$($1_base_dir)/$(BOARD)" && \
Comment on lines +448 to +451
Copy link

Copilot AI Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Makefile now removes and recreates board directories every time submodules are updated. This aggressive cleaning approach could cause issues if other build artifacts or files exist in these directories that shouldn't be removed. The cleaning happens unconditionally even when it may not be necessary (e.g., when submodules haven't actually changed). Consider making this cleaning conditional or documenting why this aggressive approach is needed.

Copilot uses AI. Check for mistakes.
echo "INFO: Updating .canary file with new repo info" && \
echo -n '$($1_repo)|$($1_commit_hash)' > "$$@" ; \
fi
Expand Down
Loading