ublk: restore auto buf unregister refcount optimization #519
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 4ded82c |
blktests-ci
bot
force-pushed
the
for-next_base
branch
from
773b514 to
18a2fa8
Compare
Author
|
Upstream branch: 1171e38 |
blktests-ci
bot
force-pushed
the
series/1048257=>for-next
branch
from
ceaabb9 to
648d151
Compare
blktests-ci
bot
force-pushed
the
for-next_base
branch
from
18a2fa8 to
25863a6
Compare
Author
|
Upstream branch: d4b7351 |
blktests-ci
bot
force-pushed
the
series/1048257=>for-next
branch
from
648d151 to
8236fa6
Compare
Commit 1ceeedb ("ublk: optimize UBLK_IO_UNREGISTER_IO_BUF on daemon task") optimized ublk request buffer unregistration to use a non-atomic reference count decrement when performed on the ublk_io's daemon task. The optimization applied to auto buffer unregistration, which happens as part of handling UBLK_IO_COMMIT_AND_FETCH_REQ on the daemon task. However, commit b749965 ("ublk: remove ublk_commit_and_fetch()") reordered the ublk_sub_req_ref() for the completed request before the io_buffer_unregister_bvec() call. As a result, task_registered_buffers is already 0 when io_buffer_unregister_bvec() calls ublk_io_release() and the non-atomic refcount optimization doesn't apply. Move the io_buffer_unregister_bvec() call back to before ublk_need_complete_req() to restore the reference counting optimization. Signed-off-by: Caleb Sander Mateos <[email protected]> Fixes: b749965 ("ublk: remove ublk_commit_and_fetch()") Reviewed-by: Ming Lei <[email protected]>
Author
|
Upstream branch: d4b7351 |
blktests-ci
bot
force-pushed
the
series/1048257=>for-next
branch
from
8236fa6 to
85e90e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: ublk: restore auto buf unregister refcount optimization
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1048257