md/md-llbimtap: fix two corner case problems #507
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 6208587 |
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
067dca5 to
1dff21b
Compare
Author
|
Upstream branch: d91a46d |
blktests-ci
bot
force-pushed
the
series/1046430=>linus-master
branch
from
f026438 to
47ff00d
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
1dff21b to
b44af19
Compare
Author
|
Upstream branch: fcb70a5 |
blktests-ci
bot
force-pushed
the
series/1046430=>linus-master
branch
from
47ff00d to
a5025c6
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
b44af19 to
483aa43
Compare
When llbitmap bit state is still unwritten, any new write should force rcw, as bitmap_ops->blocks_synced() is checked in handle_stripe_dirting(). However, later the same check is missing in need_this_block(), causing stripe to deadloop during handling because handle_stripe() will decide to go to handle_stripe_fill(), meanwhile need_this_block() always return 0 and nothing is handled. Fixes: 5ab829f ("md/md-llbitmap: introduce new lockless bitmap") Signed-off-by: Yu Kuai <[email protected]> Reviewed-by: Li Nan <[email protected]>
When llbitmap_suspend_timeout() times out waiting for percpu_ref to become zero, it returns -ETIMEDOUT without resurrecting the percpu_ref. The caller (md_llbitmap_daemon_fn) then continues to the next page without calling llbitmap_resume(), leaving the percpu_ref in a killed state permanently. Fix this by resurrecting the percpu_ref before returning the error, ensuring the page control structure remains usable for subsequent operations. Fixes: 5ab829f ("md/md-llbitmap: introduce new lockless bitmap") Signed-off-by: Yu Kuai <[email protected]> Reviewed-by: Li Nan <[email protected]>
Author
|
Upstream branch: 8dfce89 |
blktests-ci
bot
force-pushed
the
series/1046430=>linus-master
branch
from
a5025c6 to
f874326
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: md/md-llbimtap: fix two corner case problems
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1046430