new: [STORIF-187] - Global quota usage table created. #13197
Conversation
dchyrva-akamai
force-pushed
the
feature/STORIF-187
branch
3 times, most recently
from
e492df1 to
1c7f2aa
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-187
branch
3 times, most recently
from
6c6c081 to
154edf3
Compare
dchyrva-akamai
requested review from
cliu-akamai
and removed request for
a team
dchyrva-akamai
force-pushed
the
feature/STORIF-187
branch
2 times, most recently
from
6d4cd7e to
dbcea0e
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-187
branch
4 times, most recently
from
67ab331 to
ff1f699
Compare
|
This PR is stale because it has been open 15 days with no activity. Please attend to this PR or it will be closed in 5 days |
dchyrva-akamai
force-pushed
the
feature/STORIF-187
branch
from
ff1f699 to
4d7ce9a
Compare
| globalQuota: GlobalQuotaWithUsage; | ||
| } | ||
|
|
||
| const quotaRowMinHeight = 58; |
There was a problem hiding this comment.
move this to a constant file as QUOTA_ROW_MIN_HEIGHT since reused in multiple components
There was a problem hiding this comment.
Good idea, updated the code.
| setMethod('GET'), | ||
| setXFilter(filter), | ||
| setParams(params), | ||
| ); |
There was a problem hiding this comment.
Do you need a "get all" method as well? Could we have more than 500 records?
There was a problem hiding this comment.
Currently there is only one object in the list and I think there won't be more than 25 global quotas at all.
We ain't gonna need it =)
| const globalQuotaIds = | ||
| globalQuotas?.data.map((quota) => quota.quota_id) ?? []; | ||
| const globalQuotaUsageQueries = useQueries({ | ||
| queries: globalQuotaIds.map((quotaId) => |
There was a problem hiding this comment.
How many quota IDs could you end up having to fetch in parallel? Asking because this could end up being a bad performance bottleneck if running queries for dozens (hundreds) of IDs.
There was a problem hiding this comment.
The decision to fetch quota usage like this was made by the Architect, currently there is only one global quota in the object-storage, and I don't think there will ever be more than 25.
dchyrva-akamai
force-pushed
the
feature/STORIF-187
branch
3 times, most recently
from
a2e5712 to
5e50de3
Compare
dchyrva-akamai
force-pushed
the
feature/STORIF-187
branch
from
5e50de3 to
6e7c8c5
Compare
Cloud Manager UI test results🔺 1 failing test on test run #18 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
3 participants
Description 📝
Global quota usage table created.
Changes 🔄
useGetObjGlobalQuotasWithUsagehook.GlobalQuotasTablecomponent.Preview 📷
How to test 🧪
docker-compose up -d apinext..envfile of the Cloud Manager to use local API instance.pnpm dev/quotaspage.Related PRs
apinext
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅