Fixed possible range mutation of the same attribute - #239
Open
arielpollack wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UITextViewcan split anNSAttributedStringand set newfontattribute if some substring has a different language which needs another font (for example when the mention include both English and Korean, the Korean substring will have anotherfontattribute then the default one set to thatUITextView).After the "split", each substring still had the same pointer to the same
HKWMentionsAttribute, which repeatedly changed itsrangeto the latest, and then made thebufferinclude the sameHKWMentionsAttributepointer multiple times and prevented access to all mention attributes.Here I just created a new attribute and set the range to it, so at least we can iterate all ranges and decide if we want to merge or not, depending on the use case.