Skip to content

Fixed possible range mutation of the same attribute - #239

Open
arielpollack wants to merge 3 commits into
linkedin:masterfrom
DaPulse:master
Open

Fixed possible range mutation of the same attribute#239
arielpollack wants to merge 3 commits into
linkedin:masterfrom
DaPulse:master

Conversation

@arielpollack

Copy link
Copy Markdown

UITextView can split an NSAttributedString and set new font attribute if some substring has a different language which needs another font (for example when the mention include both English and Korean, the Korean substring will have another font attribute then the default one set to that UITextView).
After the "split", each substring still had the same pointer to the same HKWMentionsAttribute, which repeatedly changed its range to the latest, and then made the buffer include the same HKWMentionsAttribute pointer multiple times and prevented access to all mention attributes.

Here I just created a new attribute and set the range to it, so at least we can iterate all ranges and decide if we want to merge or not, depending on the use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant