fix: drop removed smg subsystems (Skills/memory/blob_storage), add least_load policy#18
Merged
Merged
Conversation
…ast_load policy Sync the dev-guide with 21 upstream smg commits since the previous baseline (a18d64f5 -> 27b528f3). smg removed three subsystems the guide documented and added a 9th load-balancing policy. Removed upstream -> dropped from the guide: - Skills API: crates/skills, crates/protocols/skills.rs, routers/skills (smg#1612) - blob_storage crate (backed Skills) - conversation memory: model_gateway/src/memory/ + data_connector conversation-memory writer/background (smg#1613, #1631) Changes: - delete skills/implement/memory-feature.md (subsystem gone) - map: remove the skills + blob_storage crate rows, the Memory subsystem row, and "Skills" from the provider-routers list; 8 -> 9 routing policies - implement/SKILL.md: drop the memory detection row and the Skills no-recipe row - storage-backend.md: StorageBundle is now three handles (conversation_memory_writer and background_repository removed); drop ConversationMemoryWriter references - routing-policy.md: 8 -> 9 policies (add least_load); rename the hypothetical example least_loaded -> my_policy so it no longer collides with the new real least_load policy (smg#1629; weight param renamed in #1632) - mesh-feature.md: note the MeshAdapters gateway composition root (model_gateway/src/mesh/wiring.rs, smg#1626) - README + plugin manifests: 20 -> 19 recipes Verified against smg@27b528f3. Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
21 commits landed in
smgsince the dev-guide's last verification baseline (a18d64f5→27b528f3). Several removed subsystems the guide documents, and one added a routing policy:crates/skills,crates/protocols/skills.rs,routers/skills(smg#1612)blob_storagecrate (backed Skills)model_gateway/src/memory/+ the data_connector conversation-memory writer/background (smg#1613, #1631)least_loadload-balancing policy → 9 policies now (smg#1629; weight param renamedkv_pressure_weightin #1632)MeshAdaptersgateway composition root (mesh/wiring.rs, smg#1626)Solution
Sync the guide to the current code: delete the stale recipe, drop the removed subsystems from map/implement/README/manifests, bump the policy count, trim the now-3-field
StorageBundle, and de-collide the routing-policy example.Changes
skills/implement/memory-feature.md(subsystem removed)skills+blob_storagecrate rows, the Memory subsystem row, and "Skills" from the provider-routers list; 8 → 9 routing policies (overview + subsystems table)StorageBundleis now three handles — removedconversation_memory_writer+background_repositoryand allConversationMemoryWriterreferencesleast_load); rename the hypothetical exampleleast_loaded→my_policyso it no longer collides with the new realleast_loadpolicyMeshAdaptersgateway composition root (model_gateway/src/mesh/wiring.rs) — engines registered before gossipAffected Skills
smg:mapsmg:contributesmg:review-prsmg:implementmemory-feature; updatedstorage-backend,routing-policy,mesh-feature)smg.md)plugin.json,marketplace.json, cursor)Checklist
git commit -s)claude plugins add .locally@file.mdreferences in skills