Skip to content

test: fix stale fixtures in test_loop_cleanup #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
torchspec-bot merged 1 commit into from
Jul 1, 2026
Merged

test: fix stale fixtures in test_loop_cleanup #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/test_loop_cleanup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ def test_run_training_loop_finally_runs_cleanup_on_success(self):
args=args,
inference_manager=inference_manager,
inference_future=inference_future,
inference_engines=None,
)

def test_run_training_loop_finally_runs_cleanup_on_exception(self):
Expand All @@ -71,6 +72,7 @@ def test_run_training_loop_finally_runs_cleanup_on_exception(self):
args=args,
inference_manager=inference_manager,
inference_future=inference_future,
inference_engines=None,
)


Expand Down Expand Up @@ -184,6 +186,7 @@ def test_setup_eval_dispatch_bs_is_dp_size():
args = SimpleNamespace(
eval_interval=50,
dp_size=2,
inference_batch_size=4,
max_sample_pool_size=64,
checkpoint_dir=None,
cache_dir="./cache",
Expand Down Expand Up @@ -216,6 +219,7 @@ def test_setup_eval_dispatch_bs_caps_at_dataset_size():
args = SimpleNamespace(
eval_interval=50,
dp_size=8,
inference_batch_size=4,
max_sample_pool_size=64,
checkpoint_dir=None,
cache_dir="./cache",
Expand Down
Loading