build: bump version to v0.21.0-beta.rc3#10847
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine version bump for the v0.21 release branch to reflect the latest beta release candidate. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
PR Severity: MEDIUM
Medium (1 file)
AnalysisThis PR makes a minimal change to No severity bump applies: only 1 non-test, non-generated file changed (threshold: >20), and only 2 lines changed (threshold: >500). To override, add a |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
ziggie1984
force-pushed
the
bump-version-v0.21.0-rc3
branch
from
c1d7b04 to
06436c6
Compare
|
Let's wait for #10838 to be merged |
saubyk
left a comment
saubyk
left a comment
There was a problem hiding this comment.
Aren't we mixing concerns here? Warrants an explanation at least
ziggie1984
force-pushed
the
bump-version-v0.21.0-rc3
branch
2 times, most recently
from
e7dbbda to
431499f
Compare
|
Blocker is #10851, thats def a must |
In this commit, we drop the in-tree queue replace now that queue/v1.2.0 is tagged, and pull it in as a normal dependency. The tagged release is byte-identical to the queue package we've been building in-tree on this branch, so it's a no-op for what ships in rc3: we just stop carrying the local replace. We leave the sqldb replace alone (still gated on the gossip V2 sqldb work), and kvdb stays on v1.4.16/pgx-v4 for 0.21, so the pgx/v5 migration doesn't ride along into the release.
Remove the local sqldb replace now that the required changes are available in the v1.0.13 module release. This lets the root module consume the tagged sqldb dependency directly.
Use tagged btcwallet v0.16.18. It includes the neutrino ChainService Start context signature update. Downstream module resolution can otherwise select the older v0.16.17 tag over lnd's previous pseudo-version requirement.
ziggie1984
force-pushed
the
bump-version-v0.21.0-rc3
branch
from
a4e90df to
02dc7f8
Compare
ziggie1984
force-pushed
the
bump-version-v0.21.0-rc3
branch
from
02dc7f8 to
79e0d6b
Compare
github-actions
Bot
added
severity-medium
ziggie1984
merged commit 37fe1ea
into
lightningnetwork:v0.21.x-branch
4 participants
Summary
Bumps the v0.21 release branch version from
v0.21.0-beta.rc2tov0.21.0-beta.rc3.This also updates release-branch module requirements so downstream
consumers can resolve tagged modules without relying on local replaces:
github.com/btcsuite/btcwallettov0.16.18, which containsthe neutrino
ChainService.Start(context.Context)compatibility fix.github.com/lightningnetwork/lnd/queuetov1.2.0and removesthe local
replace github.com/lightningnetwork/lnd/queue => ./queue.github.com/lightningnetwork/lnd/sqldbtov1.0.13and removesthe local
replace github.com/lightningnetwork/lnd/sqldb => ./sqldb.The replace removals matter for downstream users because Go does not
propagate replace directives from dependencies. Consumers of the v0.21
module graph now resolve the tagged
queue,sqldb, andbtcwalletversions directly.
Test plan
go test ./buildgo list -m github.com/btcsuite/btcwallet