Make get_jwt_token method public#41
Make get_jwt_token method public#41johncantrell97 wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Hmm, if we do this, we'd also need a way to expose the VssClient/LnUrlAuthProvider from LDK Node. Tbh. the only way I think we should do this is by doing a larger refactor upstream the VssStore implementation to lightning-persister (which we intended to do since the start, but never did), and have LDK Node simply take it as any other KVStore implementation (mod maybe keeping some convenience methods on the builder). Then users can build/configure the VssStore indpendently to their liking and just hand it into LDK node.
| } | ||
|
|
||
| async fn get_jwt_token(&self, force_refresh: bool) -> Result<String, VssHeaderProviderError> { | ||
| pub async fn get_jwt_token(&self, force_refresh: bool) -> Result<String, VssHeaderProviderError> { |
There was a problem hiding this comment.
Wouldn't you already get an exposed variant of this as part of the VssHeaderProvider::get_headers impl below?
If we make this public, this needs docs.
|
👋 I see @tnull was un-assigned. |
|
Closing this as abandoned. Let us know if you still need this/think this is useful, we can then work on a solution. |
3 participants
Makes this LnurlAuth implementation usable for other purposes outside of vss. Perhaps it should be extracted to it's own crate instead.