Fix CI: adapt to libKriging .travis-ci/ → tools/ rename#22
Merged
yannrichet merged 2 commits intomasterfrom Mar 18, 2026
Merged
Fix CI: adapt to libKriging .travis-ci/ → tools/ rename#22yannrichet merged 2 commits intomasterfrom
yannrichet merged 2 commits intomasterfrom
Conversation
The libKriging submodule (PR#314) renamed .travis-ci/ to tools/. This broke the R package build because tools/build.sh could not find the CI scripts directory. Changes: - tools/build.sh: detect tools/common (new) before falling back to travis-ci (legacy) for CI scripts directory - tools/setup.sh: only run .travis-ci rename+sed when directory actually exists; skip cleanly for new layout - install_github.yml: install remotes alongside devtools, since devtools 2.5.0 requires it for install_github() Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The latest libKriging submodule update (PR#314) renamed
.travis-ci/totools/. This broke CI in two ways:Build failure (
R-CMD-check,submit-CRAN,R-CMD-INSTALL-build)tools/build.shusedls -a | grep travis-cito find CI scripts insidesrc/libK/. Since.travis-ci/no longer exists, the cmake build never ran → noinst/includegenerated →lkalloc.hpp: No such file or directory.install_github failure
devtools2.5.0 deprecatedinstall_github()and requires theremotespackage, which wasn't being installed.Fix
tools/build.sh: Detecttools/common(new layout) before falling back totravis-ci(legacy)tools/setup.sh: Only run.travis-cirename when directory actually existsinstall_github.yml: Installremotesalongsidedevtools