Merged
Conversation
# Conflicts: # DependencyInjection/LexikTranslationExtension.php # composer.json
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I based this on the PR #501. I mostly had to resolve the conflicts and add some configuration in my Symfony 8 project, such as the correct database url, but other than that I think the original PR is unchanged. Once this is merged, the bundle will work with Symfony 8. I know this might not be the best solution. When @dsoriano finishes his work to improve this, we will merge that and have a better solution (with a decorator translator).