Add AlreadyRevoked handling to revokedCertificates table inserts#8408
Draft
aarongable wants to merge 6 commits intomainfrom
Draft
Add AlreadyRevoked handling to revokedCertificates table inserts#8408aarongable wants to merge 6 commits intomainfrom
aarongable wants to merge 6 commits intomainfrom
Conversation
jprenken
previously approved these changes
Sep 24, 2025
jsha
requested changes
Sep 25, 2025
jprenken
previously approved these changes
Oct 3, 2025
jsha
requested changes
Oct 20, 2025
Contributor
jsha
left a comment
There was a problem hiding this comment.
Sorry for the delay. I had a pending comment in here I thought I'd already sent.
jprenken
previously approved these changes
Oct 20, 2025
e1c002b to
d444864
Compare
Contributor
Author
|
I've updated this PR to make the serials index unique, and then rely on detecting duplicate inserts, like the first draft. I've updated IN-11835 to indicate that the new index should be unique. I think that including the index update in this PR, rather than as a predecessor PR that must be deployed first, is fine because the inserts into this table are still actually protected by the updates to the |
jprenken
previously approved these changes
Oct 22, 2025
jsha
requested changes
Oct 28, 2025
jprenken
approved these changes
Oct 28, 2025
jsha
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within
sa.addRevokedCertificate, detect if the insert failed due to a duplicate primary key, and returnberrors.AlreadyRevokedin that case. This matches the behavior ofsa.RevokeCertificatewhen an update to thecertificateStatustable modifies no rows.This change has no immediate impact, because addRevokedCertificate is only called after RevokeCertificate's update to the certificateStatus table has succeeded: if the first operation returns AlreadyRevoked, this code is never reached. However, we plan to remove the certificateStatus table in the future, so this code will need to return AlreadyRevoked when appropriate.
Part of #8322
Warning
Do not merge before #8427Do not merge before IN-11835 is complete