add a test to validate important scenarios. #462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
checkpwmethod incom.hellokaton.blade.kit.BCryptis not fully tested. Specifically, the current test suite does not cover the branchif (hashed_bytes.length != try_bytes.length), which handles scenarios where the stored password hashes may be corrupted. These scenarios are important to consider, as real-world issues—often introduced during database migrations or system updates—can lead to such inconsistencies.To address this gap, I’ve added a test that explicitly validates this scenario. I hope it proves helpful in detecting potential regressions.
If additional test coverage would be valuable, I’d be happy to contribute further by looking into other classes you consider important for a follow-up PR.