Skip to content

[pull] main from gi-dellav:main#79

Merged
pull[bot] merged 6 commits into
lenylvt:mainfrom
gi-dellav:main
Jun 28, 2026
Merged

[pull] main from gi-dellav:main#79
pull[bot] merged 6 commits into
lenylvt:mainfrom
gi-dellav:main

Conversation

@pull

@pull pull Bot commented Jun 28, 2026

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

Note

Add process group tracking and timeout-aware command execution to Sandbox

  • Adds Sandbox::output_command to execute commands while safely capturing stdout/stderr even when background descendants hold pipes open; kills the process group on hang.
  • Introduces ProcessGroupGuard to track active child process groups in active_groups, and Sandbox::kill_active to terminate all tracked groups.
  • On Unix, child processes are placed into their own process group via configure_child_lifetime, enabling group-wide termination with kill_process_group.
  • BashTool::call now uses output_command and returns a timeout error (killing active groups) when a command exceeds its deadline.
  • Cancelling a run or pressing Ctrl-C in the UI now calls sandbox.kill_active() to clean up any running descendants.
  • Fixes an off-by-end panic in ReadTool when reading with an offset beyond EOF by clamping to file length.

Macroscope summarized 2eb9e50.

@pull pull Bot locked and limited conversation to collaborators Jun 28, 2026
@pull pull Bot added the ⤵️ pull label Jun 28, 2026
@pull pull Bot merged commit 2eb9e50 into lenylvt:main Jun 28, 2026
1 check failed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants