refactor: use simp_to_model for TreeMap mergeWith - #532
Open
ctkrug wants to merge 1 commit into
Open
Conversation
Collaborator
|
Awesome! Thanks for figuring this out. |
ctkrug
marked this pull request as ready for review
July 24, 2026 16:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the bespoke
TreeMap.mergeWithlookup proof and its private fold helpers with a directsimp_to_modelproof. This preserves both public theorem signatures while replacing 122 lines of implementation-specific machinery with a 10-line model-based proof.This draft depends on the Std model bridge in leanprover/lean4#14526.
Validation performed on the exact committed diff:
simp_to_modelbridge checkerFixes #127.
Checklist
Generative AI Guidelines
AI assistance was used to investigate and draft the refactor. The final proof was manually reviewed, the duplicated constructions were removed, both public theorem signatures were preserved, and all checks listed above passed.