Fixes horizontal scrolling - #76
Conversation
|
@asos-VasilisKortsimelidis a couple things to check:
|
|
@lazd hmm ok seems it let it bounce now, oops! let me have a better look and I will update |
|
@asos-VasilisKortsimelidis yeah, this is a really tough one, see the issue for previous attempts. I honestly thing 2-axis scrolling without bounce shouldn't be possible, and that we should focus on making either vertical or horizontal scrolling work without bounce. |
Had also forgotten to set the actual overflowX variable
|
@lazd thanks for your response. In my case when I initialise iNoBounce I'm not able to scroll horizontally on an element. At this point I don't care if it's bouncing horizontally (on that particular element). My latest commit fixes that. You still get no bounce vertically but let's the element scroll horizontally. Thoughts? :) |
|
Does horizontal scrolling work when you're scrolled to the top and bottom of the element? |
It does indeed. I'm not sure of other edge cases you probably are though. I will patch it for our project but maybe we can leave the PR open and see if more people are happy with the solution. |
Fixes #50
Similarly with the code already there, check if the element has
overflow-xscroll or auto and let it scroll 😅