🎨 Palette: Convert flashcard CSS hints to ARIA-hidden DOM elements#111
🎨 Palette: Convert flashcard CSS hints to ARIA-hidden DOM elements#111lavkushry wants to merge 1 commit into
Conversation
Co-authored-by: lavkushry <106930153+lavkushry@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request addresses accessibility issues where screen readers redundantly announce text injected via CSS pseudo-elements. The changes replace CSS pseudo-elements (::before and ::after) on flashcards with actual DOM elements (.flashcard__hint and .flashcard__seen-mark) that are explicitly hidden from screen readers using aria-hidden="true". A corresponding entry has also been added to the palette documentation. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
💡 What:
Removed textual hints ("tap to flip →") and seen checkmarks ("✓") that were being injected via CSS pseudo-elements (
::before/::after) on flashcards. Replaced them with actual DOM elements that includearia-hidden="true"attributes.🎯 Why:
Screen readers cannot naturally ignore text injected via CSS
content:properties, leading to redundant and confusing announcements for screen reader users (e.g., repeating "tap to flip" indiscriminately). By using actual DOM elements witharia-hidden, the visual UI remains exactly the same while completely silencing the noise for assistive technologies.📸 Before/After:
The visual layout is unchanged (verified via automated visual regression and manual screenshot generation), but the underlying accessible DOM tree is cleaner.
♿ Accessibility:
Improves screen reader clarity by hiding decorative visual cues that otherwise clutter announcements. Added an entry to
.jules/palette.mdto document this critical CSS accessibility learning for future reference.PR created automatically by Jules for task 14783451160313123447 started by @lavkushry