Skip to content

Conversation

@keelerm84
Copy link
Member

@keelerm84 keelerm84 commented Jan 30, 2026

Note

Medium Risk
Changes core data-synchronization failover logic (including FDv1 fallback) and alters config shape/API, which can affect initialization and runtime update behavior across environments.

Overview
Updates the experimental data system configuration to use an ordered list of synchronizers rather than primary_synchronizer/secondary_synchronizer, and updates the builder API (ConfigBuilder.synchronizers(*builders)) to require at least one synchronizer.

Refactors the FDv2 runtime to iterate through any number of synchronizers with generalized fallback/recovery behavior (including permanent removal on failure and optional switch to the FDv1 fallback synchronizer), and updates contract-test parsing plus unit tests to match the new list-based configuration.

CI contract tests are bumped to v3.0.0-alpha.3 and YAML quoting is normalized for boolean-like inputs.

Written by Cursor Bugbot for commit 697b0c2. This will update automatically on new commits. Configure here.

@keelerm84 keelerm84 requested a review from a team as a code owner January 30, 2026 22:25
@keelerm84 keelerm84 force-pushed the mk/sdk-1777/sync-list branch from e1a1a0e to 8da2666 Compare January 30, 2026 22:25
Copy link
Contributor

@jsonbailey jsonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion but don't consider it a blocker.

condition_func: Callable[[DataSourceStatus], bool]
) -> tuple[bool, bool]:
condition_func: Callable[[DataSourceStatus], ConditionDirective]
) -> tuple[bool, bool, ConditionDirective]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Ruby I ended up collapsing this down to a single result, essentially adding the remove sync and fallback as options of the Conditional Directive. From my understanding they are all independent of each other. If you have fallback, you don't care about the other two, if you have remove sync, you don't care about the conditional directive, so there isn't a need to have all three returned.

@keelerm84 keelerm84 force-pushed the mk/sdk-1777/sync-list branch from c62e0c3 to 9e2c297 Compare February 3, 2026 13:46
Base automatically changed from mk/sdk-1791/subconfig to main February 4, 2026 13:06
@keelerm84 keelerm84 force-pushed the mk/sdk-1777/sync-list branch from 9e2c297 to 697b0c2 Compare February 4, 2026 13:07
@keelerm84 keelerm84 merged commit c73ad14 into main Feb 4, 2026
15 checks passed
@keelerm84 keelerm84 deleted the mk/sdk-1777/sync-list branch February 4, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants