fix: Fix data and target availability for daemon mode#385
Draft
fix: Fix data and target availability for daemon mode#385
Conversation
kinyoklion
approved these changes
Dec 3, 2025
4804ac1 to
efcf0cb
Compare
efcf0cb to
1c998cd
Compare
| return DataAvailability.REFRESHED | ||
|
|
||
| if not self._configured_with_data_sources or self._store.is_initialized(): | ||
| if self._store.is_initialized(): |
There was a problem hiding this comment.
Bug: Missing offline check in FDv2 data_availability property
The data_availability property in FDv2 is missing an offline check, unlike target_availability which explicitly checks self._config.offline and returns DEFAULTS. In FDv1, both properties check for offline mode first. Without this check, if the store happens to be initialized while in offline mode, data_availability would return CACHED instead of DEFAULTS, creating inconsistent behavior between the two availability properties and between FDv1 and FDv2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adjust availability calculations in FDv1/FDv2 and add tests for offline, LDD, data-source, and store-initialization states.
ldclient/impl/datasystem/fdv1.py):data_availabilityto returnCACHEDin LDD mode only when the store is initialized; otherwiseDEFAULTS.target_availabilityto returnCACHEDin LDD mode;DEFAULTSwhen offline; otherwiseREFRESHED.ldclient/impl/datasystem/fdv2.py):config.offlinedirectly instart()to disable the system.data_availability:REFRESHEDwhen selector is defined;CACHEDwhen store initialized; elseDEFAULTS.target_availability:DEFAULTSwhen offline or no data sources and no store;REFRESHEDwhen configured with data sources; otherwiseCACHED.test_fdv1_availability.pycovering offline, LDD (initialized/uninitialized), and normal mode scenarios.test_fdv2_datasystem.pywith availability cases for offline, with/without data sources, and read-only/read-write store (initialized/uninitialized).Written by Cursor Bugbot for commit 1c998cd. This will update automatically on new commits. Configure here.