Make it compatible with Jira 8 and other SAML apps - #6
Open
max-allan-surevine wants to merge 4 commits into
Open
Make it compatible with Jira 8 and other SAML apps#6max-allan-surevine wants to merge 4 commits into
max-allan-surevine wants to merge 4 commits into
Conversation
added 4 commits
February 14, 2019 14:44
…heck for null member list
…t path Unlike the confluence version, which seems OK...
|
Thank you! I was just starting to write the ComponentManager fix as well. Unfortunately I'm not sure anyone at LastPass still cares about this since @bcopeland left. :( |
Author
|
I've raised a ticket with LastPass, suggested they get one of their own devs to look at my "alternative context" quick fix. Iirc, it will add "null" to the URL if you host jira in / , and of course /null gets a 404 response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow you to use the plugins with Jira 8.
It also makes it work if your jira is not in the context path /.
(Although does have issues when it is / . Needs a better Java person than me to figure out!)
And sets username/email/etc sensibly rather than assuming username is email everywhere and not setting real names.