Add context path to the redirect URL in saml_login.jsp#1
Open
max-allan-surevine wants to merge 2 commits into
Open
Add context path to the redirect URL in saml_login.jsp#1max-allan-surevine wants to merge 2 commits into
max-allan-surevine wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NB I am no java dev and no virtually nothing about Confluence's internal workings, so this may be an awful way to make it work!
I was using confluence with a context path and noticed that logins worked but redirected me to a URL without the context path. Looking at packets shows :
GET /confluence/display/SIC/Hello HTTP/1.1gets a 302 redirect to
Location: /confluence/login.action?os_destination=%2Fpages%2Fviewpage.action%3FspaceKey%3DSIC%26title%3DHello&permissionViolation=trueWith the default authenticator.
However, with the SAML plugin, redirect to :
Location: /confluence/saml_login.jsp?os_destination=%2Fpages%2Fviewpage.action%3FspaceKey%3DSIC%26title%3DHelloAnd the redirect uri includes the os_destination but not the context path.
My simple fix could maybe do with some logic if context path is "" but I think adding "" to the rest of the path is probably safe enough. I don't know if the os_destination should ever include the context. I couldn't find any docs about what it is supposed to be.