[TENT] Bind transport policies to intent type#2847
Conversation
|
Replacement for #2839 using branch Cluster validation on two H20 nodes for commit Environment:
Passed:
Notes / not counted as pass criteria for this PR:
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for business intent-based policy binding (intent_type) in the transport selector, allowing requests to match specific transport policies based on their intent (e.g., foreground_get, background_prefetch, checkpoint). The changes span the policy configuration parser, selection matching logic, benchmark tool, documentation, and unit tests. Feedback suggests converting the command-line argument --tent_intent_type to lowercase in the benchmark backend to ensure case-insensitive parsing consistency with the policy configuration parser.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Follow-up validation for the mixed-case intent fix at
All review threads are resolved. Full GitHub CI is now running/queued. |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Summary
Request::intent_typeinto transport policy selectionintent_typefilter in configured TENT policiespolicy_nameoverridesCompatibility
Policies without
intent_typematch every intent exactly as before. Requestswith
INTENT_UNSPECtherefore retain the existing selection behavior unless anoperator explicitly configures an
intent_unspecrule.Test plan
tent_transport_selector_testandtent_intent_type_testServer validation used commit
964a590d, fetched directly from GitHub. Theupstream GitHub Actions matrix is still running; this PR remains Draft until
the TENT CUDA-on/off jobs complete.