Handle Ctrl+C when images are being pulled when dojo action is: run#15
Handle Ctrl+C when images are being pulled when dojo action is: run#15
Conversation
I don't think this is acceptable solution. It should not pull images before each run. The cases where it might have bad consequences are:
Then pull would either get something that developer does not want on their workstation yet, or completely fail in the later case when pulling We should keep the default docker behavior for runs - pull only when image is missing locally. Rather than calling pull explicitly, I think you should handle the signals to simply interrupt the |
|
Good points, I will rethink the implementation for the docker-compose driver. |
01e664d to
4387efa
Compare
This PR fixes #1.
For the driver: docker - a SIGINT is sent to the current process group.
For the driver: docker-compose - Dojo will first explicitly invoke the pull action.
Besides, this PR also fixes a minor bug which happened on handling signals for the driver: docker-compose when a default container was not created. Dojo used to panic then, now it will proceed with cleaning.