Skip to content

Update the doc for windows server 2025 support #53349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zylxjtu wants to merge 1 commit into
base: dev-1.35
Choose a base branch
from
Open

Update the doc for windows server 2025 support #53349

zylxjtu wants to merge 1 commit into from

Conversation

@zylxjtu
Copy link
Contributor

@zylxjtu zylxjtu commented Nov 20, 2025

Description

Issue

Closes: #

@k8s-ci-robot k8s-ci-robot added this to the 1.35 milestone Nov 20, 2025
@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/en Issues or PRs related to English language labels Nov 20, 2025
@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Nov 20, 2025
@netlify
Copy link

netlify bot commented Nov 20, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit b5403b9
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/692f5a33af875c00085d1420

@k8s-ci-robot k8s-ci-robot added language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 20, 2025
@windsonsea
Copy link
Member

windsonsea commented Nov 25, 2025

Hi @zylxjtu, please only include a single language (such as english) in this PR, and leave other variations for different localization teams.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2025
@zylxjtu
Copy link
Contributor Author

zylxjtu commented Dec 1, 2025

Hi @zylxjtu, please only include a single language (such as english) in this PR, and leave other variations for different localization teams.
reverted the changes other than english

@netlify
Copy link

netlify bot commented Dec 1, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b5403b9
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/692f5a331b38270007eaf46f
😎 Deploy Preview https://deploy-preview-53349--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

marosset
marosset reviewed Dec 1, 2025
View reviewed changes
content/en/docs/concepts/windows/intro.md Outdated
: Windows Server 2022
: Windows Server 2025

Windows Server SAC release
Copy link
Contributor

@marosset marosset Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the SAC release?

Copy link
Contributor Author

@zylxjtu zylxjtu Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

marosset
marosset reviewed Dec 1, 2025
View reviewed changes
content/en/docs/concepts/windows/user-guide.md
|--------------------------------------|------------------------|
| Windows Server 2019 | 10.0.17763 |
| Windows Server 2022 | 10.0.20348 |
| Windows Server 2025 | 10.0.26100 |
Copy link
Contributor

@marosset marosset Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the node.kubernetes.io/windows-build example node selector values above and below this too? They reference the Windows Server 2019 OS version which is being removed from this table

Copy link
Contributor Author

@zylxjtu zylxjtu Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 2, 2025
@zylxjtu
Copy link
Contributor Author

zylxjtu commented Dec 3, 2025

@sig-docs-website-owners, can anyone please help to take a look at and approve this PR? @edsoncelio @jongwooo

marosset
marosset approved these changes Dec 3, 2025
View reviewed changes
Copy link
Contributor

@marosset marosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marosset, msft-linliu, timmy-wright
Once this PR has been reviewed and has the lgtm label, please assign salaxander for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 3, 2025

LGTM label has been added.

DetailsGit tree hash: e3ff40393dfe764edae6d7c21a1b11e80f4ace5c

@windsonsea
Copy link
Member

windsonsea commented Dec 4, 2025

/remove-language ko pt zh
/remove-area localization

@k8s-ci-robot k8s-ci-robot removed language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language area/localization General issues or PRs related to localization labels Dec 4, 2025
@natalisucks
Copy link
Contributor

natalisucks commented Dec 4, 2025

/hold
am adding @dipesh-rawat's questions from the related Slack thread in #sig-release so we can have clarity on this PR, given the docs freeze is now in effect:

Could you provide some context on this PR because the description does not include any details. It would help to know if the doc PR relates to any KEP that is part of v1.35. If that is the case then a link to the KEP would be very useful. If it is not connected to a KEP then it would be good to understand why this update is intended for the v1.35 docs rather than the current live docs on main branch

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2025
@zylxjtu
Copy link
Contributor Author

zylxjtu commented Dec 4, 2025

/hold am adding @dipesh-rawat's questions from the related Slack thread in #sig-release so we can have clarity on this PR, given the docs freeze is now in effect:

Could you provide some context on this PR because the description does not include any details. It would help to know if the doc PR relates to any KEP that is part of v1.35. If that is the case then a link to the KEP would be very useful. If it is not connected to a KEP then it would be good to understand why this update is intended for the v1.35 docs rather than the current live docs on main branch

No, this doc PR does not relate to any KEP of v1.35. it is just to indicate the support of windows 2025 in v1.35 release. it has not been tested on all the supported k8s release, so we feel it might not be time to target the main branch yet.

@natalisucks
Copy link
Contributor

natalisucks commented Dec 5, 2025

Per instructions from @katcosgrove and agreement in the above-mentioned thread, please update the PR description to include that this is documenting a change in CI validation and also change the branch to target main. This is to ensure that we as docs reviewers understand the change. @zylxjtu it is always recommended to have a PR description for all changes being made upstream to Kubernetes.

This PR can be unheld after the v1.35 release in two weeks, given that we won't be opening an exception request for this change (and has been agreed to by needed collaborators).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edsoncelio edsoncelio Awaiting requested review from edsoncelio

@jongwooo jongwooo Awaiting requested review from jongwooo

3 more reviewers

@timmy-wright timmy-wright timmy-wright approved these changes

@marosset marosset marosset approved these changes

@msft-linliu msft-linliu msft-linliu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marosset marosset

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

1.35

Development

Successfully merging this pull request may close these issues.

7 participants

@zylxjtu @windsonsea @k8s-ci-robot @natalisucks @timmy-wright @marosset @msft-linliu