-
Notifications
You must be signed in to change notification settings - Fork 2.8k
cleanup stale OWNERS / test-infra-oncall #36070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenTheElder
commented
Dec 10, 2025
- @stevekuznetsov and @krzyzacy are not actively reviewing here => emeritus
- test-infra-oncall does not exist anymore since moving things to sig k8s infra
- @michelle192837 could be a trusted root approver if desired, for now documenting as emeritus
- @dims and I do not have approval for image-pushing jobs anymore since stepping down from sig-k8s-infra, but are still assigned as reviewers, updating reviewers to be accurate for those
- sig testing generally grants ownership to individuals based on their contributions, not to leads aliases (Which are also incorrect shorthand when including chairs + TLs, these are technical ownership), clarifying that
…to emeritus (instead of reviewer but no approval permisions)
|
/hold |
| - upodroid | ||
| emeritus_approvers: | ||
| - amwat | ||
| - cjwagner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this and some of the others are from the oncall alias, these folks did review and approve a lot of changes over the years, but were not necessarily listed inline here versus the alias
the alias is removed entirely as the concept is gone, so documenting here.
michelle192837
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ben!
General LGTM 👍
(I'm happy to be a root approver or not based on your judgement, either way.)
|
/lgtm |
ACK, un-emeritus-ing then :-) Thank you for all your contributions and considered reviews. |
|
/hold for others Thanks! |
michelle192837
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
krzyzacy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Ben!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, chases2, krzyzacy, michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
@BenTheElder: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |