Skip to content

Conversation

@BenTheElder
Copy link
Member

  • @stevekuznetsov and @krzyzacy are not actively reviewing here => emeritus
  • test-infra-oncall does not exist anymore since moving things to sig k8s infra
    • @michelle192837 could be a trusted root approver if desired, for now documenting as emeritus
  • @dims and I do not have approval for image-pushing jobs anymore since stepping down from sig-k8s-infra, but are still assigned as reviewers, updating reviewers to be accurate for those
  • sig testing generally grants ownership to individuals based on their contributions, not to leads aliases (Which are also incorrect shorthand when including chairs + TLs, these are technical ownership), clarifying that

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 10, 2025
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/images area/jobs area/prow/bump Updates to the k8s prow cluster area/testgrid sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 10, 2025
@BenTheElder
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2025
- upodroid
emeritus_approvers:
- amwat
- cjwagner
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this and some of the others are from the oncall alias, these folks did review and approve a lot of changes over the years, but were not necessarily listed inline here versus the alias

the alias is removed entirely as the concept is gone, so documenting here.

Copy link
Contributor

@michelle192837 michelle192837 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben!

General LGTM 👍

(I'm happy to be a root approver or not based on your judgement, either way.)

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 10, 2025
@aojea
Copy link
Member

aojea commented Dec 11, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2025
@BenTheElder
Copy link
Member Author

(I'm happy to be a root approver or not based on your judgement, either way.)

ACK, un-emeritus-ing then :-)

Thank you for all your contributions and considered reviews.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2025
@chases2
Copy link
Contributor

chases2 commented Dec 11, 2025

/hold for others

Thanks!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2025
Copy link
Contributor

@michelle192837 michelle192837 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2025
Copy link
Member

@krzyzacy krzyzacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Ben!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, chases2, krzyzacy, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit d7853fe into kubernetes:master Dec 15, 2025
6 checks passed
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-k8s-infra-apps.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-k8s-infra-apps.yaml
  • key sig-k8s-infra-prow.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-k8s-infra-prow.yaml
  • key sig-k8s-infra-test-infra.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-k8s-infra-test-infra.yaml
Details

In response to this:

  • @stevekuznetsov and @krzyzacy are not actively reviewing here => emeritus
  • test-infra-oncall does not exist anymore since moving things to sig k8s infra
  • @michelle192837 could be a trusted root approver if desired, for now documenting as emeritus
  • @dims and I do not have approval for image-pushing jobs anymore since stepping down from sig-k8s-infra, but are still assigned as reviewers, updating reviewers to be accurate for those
  • sig testing generally grants ownership to individuals based on their contributions, not to leads aliases (Which are also incorrect shorthand when including chairs + TLs, these are technical ownership), clarifying that

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder BenTheElder deleted the oncall-replace branch December 15, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/images area/jobs area/prow/bump Updates to the k8s prow cluster area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants