Skip to content

Conversation

@Jkhall81
Copy link

@Jkhall81 Jkhall81 commented Dec 12, 2025

Stabilize list benchmark by limiting QPS

This PR adds an explicit QPS limit to the request-benchmark invocation used by the list benchmark to reduce run-to-run CPU variance introduced by streaming LIST responses.

Changes:

  1. Adds a fixed --qps=500 flag to the list benchmark deployment (clusterloader2/testing/list/deployment.yaml)
  2. Ensures request rate is paced rather than unbounded when running the LIST benchmark
  3. Improves stability and repeatability of CPU usage measurements without changing benchmark semantics

Which issue(s) this PR is related to:
Fixes kubernetes/kubernetes#130869

Special notes for your reviewer:
This change intentionally uses a fixed QPS value to minimize variance with minimal surface area. The specific value is not a throughput target and can be adjusted or parameterized in a follow-up if needed. Streaming behavior and benchmark workload remain unchanged.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @Jkhall81!

It looks like this is your first PR to kubernetes/perf-tests 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/perf-tests has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 12, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Jkhall81. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jkhall81
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stabilize benchmark list by limiting QPS

2 participants