feat(chart): allow pinning the operator image by digest - #2280
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in the Helm chart to pin the logging-operator container image by digest (repo@sha256:...) instead of only by tag (repo:tag), enabling deterministic/secure image references and testing pre-release images.
Changes:
- Introduces a new optional image version override intended for digest-based references.
- Updates the Deployment template to render
image: repo@digestwhen the digest override is provided, otherwise keepsrepo:tagbehavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| charts/logging-operator/values.yaml | Documents the new image digest override value under image:. |
| charts/logging-operator/templates/deployment.yaml | Uses digest-based image reference when the new value is set; falls back to tag/appVersion otherwise. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
csatib02
changed the title
csatib02
force-pushed
the
feat/chart-sha-1
branch
from
July 28, 2026 10:34
17971c4 to
285e6fd
Compare
csatib02
approved these changes
Jul 28, 2026
The deployment template only supported `<repo>:<tag>`, so the image could not be pinned to a sha256 digest. Add an optional `image.digest` value that switches the reference to `<repo>@<digest>` when set. Signed-off-by: Frank Kloeker <frank.kloeker@telekom.de> Signed-off-by: Bence Csati <bence.csati@axoflow.com>
csatib02
force-pushed
the
feat/chart-sha-1
branch
from
July 28, 2026 11:23
285e6fd to
73a46b7
Compare
csatib02
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Operator Helm Chart the image tag of the deployment is set to the app version or can be set to a tag, but never to a sha256 checksum, because the different syntax between
<repo>:<tag>and<repo>@<sha256:tag>.Let's define an optional new Chart value where the user can a sha tag as image version. Sometimes we want to test pre-versions or user use also sha tag as security feature to get a valid image.