Skip to content

fix: 개인 일정 키보드 가림 수정#317

Merged
kswift1 merged 2 commits into
mainfrom
kswift1/personal-schedule-keyboard-overlap
Jun 1, 2026
Merged

fix: 개인 일정 키보드 가림 수정#317
kswift1 merged 2 commits into
mainfrom
kswift1/personal-schedule-keyboard-overlap

Conversation

@kswift1
Copy link
Copy Markdown
Owner

@kswift1 kswift1 commented Jun 1, 2026

Summary

  • Stop StepSheetContainer from fighting system keyboard layout by managing keyboard height as a bottom inset while the keyboard is visible.
  • Keep the bottom action area hidden during keyboard input without causing the sheet to jump up and down.
  • Preserve existing DescriptionBlockEditor internal scroll behavior without adding parent-level delayed scrolling.

Tests

  • make test-module MODULE=CreateScheduleFeature

Notes

  • Projects/Shared/Resources/Localizable.xcstrings has a pre-existing local change and is intentionally not included in this PR.

kswift1 and others added 2 commits June 1, 2026 17:36
개인 일정 입력 시트가 키보드 safe area를 반영하도록 공통 StepSheetContainer의 키보드 무시를 제거한다.

상세 설명 블록 에디터 포커스를 개인 일정 폼으로 전달해 하단 입력 영역을 키보드 위로 스크롤한다.

[테스트]\n- make test-module MODULE=CreateScheduleFeature

Co-authored-by: OpenAI Codex <noreply@openai.com>
키보드 표시 중 시스템 safe area 보정과 지연 스크롤이 충돌하지 않도록 공통 StepSheetContainer가 키보드 높이만큼의 하단 inset을 직접 제공한다.

개인 일정 상세 설명 입력에서 추가 지연 스크롤 콜백을 제거해 시트가 위로 올라갔다가 내려오는 동작을 방지한다.

[테스트]\n- make test-module MODULE=CreateScheduleFeature

Co-authored-by: OpenAI Codex <noreply@openai.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses UI layout issues encountered when the system keyboard appears within the schedule creation flow. By tracking the keyboard height and adjusting the view's bottom padding accordingly, the changes ensure a smooth user experience where the interface elements remain properly positioned without erratic jumping or obstruction.

Highlights

  • Keyboard Layout Management: Introduced a keyboardHeight state in StepSheetContainer to dynamically manage bottom insets, preventing the view from conflicting with the system keyboard.
  • UI Stability: Updated bottomFixedArea to use a clear spacer when the keyboard is visible, ensuring the sheet remains stable without jumping during input.
  • Code Formatting: Refactored the DescriptionBlockEditor initializer for improved readability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reformats the initializer in DescriptionBlockEditor.swift for improved readability and introduces dynamic keyboard height tracking in StepSheetContainer.swift. It adds a new keyboardHeight state property, updates keyboard notification handlers to calculate and animate the keyboard height, and adjusts the bottomFixedArea to display a clear placeholder frame when the keyboard is active. There are no review comments to assess, and I have no additional feedback to provide.

@kswift1 kswift1 merged commit 6be9950 into main Jun 1, 2026
2 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

PR 체크 성공

모드: 🎯 선택적 빌드 (Clients, PromisoShared)
빌드: 성공
테스트: 통과

📊 모듈별 커버리지
모듈 커버리지 상태

🔴 30% 미만 | 🟡 30~50% | 🟢 50% 이상

상세 정보
  • Workflow: PR Check
  • Branch: kswift1/personal-schedule-keyboard-overlap
  • Commit: 14ee8eb
  • 빌드 모드: 🎯 선택적 빌드 (Clients, PromisoShared)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant