feat(completion): add shell completion support#82
Merged
Conversation
Introduce shell completion support for bash, zsh, and fish shells. This includes a new `completion` command that generates the necessary scripts for each shell. Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Changelog
This pull request introduces a new feature to generate shell completion scripts for the
ksctlCLI tool, along with integrating this feature into the command mapping. The changes include the addition of a new command and its registration in the CLI.Added functionality for shell completion:
cmd/completion.go: Introduced a newShellCompletionmethod in theKsctlCommandstruct. This method provides acobra.Commandimplementation to generate shell completion scripts for Bash, Zsh, and Fish shells. It includes detailed usage instructions and handles unsupported shell inputs gracefully.Integration into the command mapping:
cmd/handler.go: Registered the newShellCompletioncommand in theCommandMappingfunction, ensuring it is available as part of the CLI.🏋🏼 Issues
✅ Completed Issues
🔍 Review Checklist
📸 Screenshots/Recordings
📌 Additional Notes
💡 PR best practices
pre-commitfor that run this command$ pre-commit install