Fixing an issue where a secret subkey wasn't being used to decrypt#188
Open
fbernardo wants to merge 1 commit into
Open
Fixing an issue where a secret subkey wasn't being used to decrypt#188fbernardo wants to merge 1 commit into
fbernardo wants to merge 1 commit into
Conversation
ghost
approved these changes
Apr 24, 2021
krzyzanowskim
requested changes
Aug 9, 2021
| let signaturePacket = subKey.bindingSignature; | ||
| if (signaturePacket.canBeUsedToEncrypt && PGPEqualObjects(PGPCast(subKey.primaryKeyPacket, PGPSecretKeyPacket).keyID, keyID)) { | ||
| //Assume the primary key packet is always capable if if its a secret key packet | ||
| if (PGPEqualObjects(PGPCast(subKey.primaryKeyPacket, PGPSecretKeyPacket).keyID, keyID)) { |
Owner
There was a problem hiding this comment.
I'm not sure if this is correct.
This makes always use the first subkey. What if there's multiple subkeys, ale there's one that is valid, and it's not the first from the list?
krzyzanowskim
added a commit
that referenced
this pull request
Aug 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case where a secret key was used only to sign and a secret subkey was then used to encrypt only, this function wasn't finding any keys to encrypt.
Similarly to how it is assumed on line 322, I changed the code to assume a secret subkey is always capable.
Checklist: