Add body getter and support multipart/form-data enctype#3
Open
elquimista wants to merge 4 commits intokoa-modules:masterfrom
Open
Add body getter and support multipart/form-data enctype#3elquimista wants to merge 4 commits intokoa-modules:masterfrom
elquimista wants to merge 4 commits intokoa-modules:masterfrom
Conversation
added 2 commits
December 28, 2016 00:00
1 similar comment
d26cb35 to
e53b5b9
Compare
Member
|
Is it better by an option? |
Author
|
I think this is improved version for sure. Original one can only handle situations where |
Member
|
I think we can use an option for enabling that. |
Author
|
@fundon what's your plan for this PR? |
Member
|
@clthck About an option? |
Author
|
I don't think providing this as an option is not appropriate. It's not something user wants to opt in/out - it should be handled by default. There's no difference in overhead or whatever if we make this feature optable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports
req.bodygetter. E.g. I was using jquery-ujs for an anchor tag withdata-method="delete". Since jquery-ujs is originally designed for rails, it used form body to send hidden input field value with name of_method. And this obviously doesn't get passed query getter.