Skip to content

Conversation

@beatrycze-volk
Copy link
Collaborator

#1015 needs data in CSV format to work.

@sebastian-meyer sebastian-meyer self-requested a review October 28, 2023 12:21
@sebastian-meyer sebastian-meyer changed the title Convert database XML fictures into CSV format [MAINTENANCE] Convert database XML fixtures into CSV format Oct 28, 2023
@sebastian-meyer sebastian-meyer added the ⟳ maintenance A task to keep the code up-to-date and manageable. label Oct 28, 2023
@beatrycze-volk beatrycze-volk force-pushed the move-tests-to-csv branch 11 times, most recently from f0710c5 to 6732fb2 Compare October 30, 2023 15:25
@beatrycze-volk beatrycze-volk force-pushed the move-tests-to-csv branch 2 times, most recently from 1db6171 to 378637d Compare October 30, 2023 16:03
@beatrycze-volk beatrycze-volk force-pushed the move-tests-to-csv branch 2 times, most recently from 4362a7f to 8df003e Compare October 30, 2023 16:30
@beatrycze-volk beatrycze-volk marked this pull request as ready for review October 30, 2023 16:33
@beatrycze-volk
Copy link
Collaborator Author

There are 3 Codacy errors but I don't see anyway to fix it.

@sebastian-meyer
Copy link
Member

All Codacy issues are just discouraged but not disallowed functions, so I added some exceptions for using those in the tests.

@sebastian-meyer sebastian-meyer self-requested a review October 31, 2023 15:38
@sebastian-meyer sebastian-meyer merged commit fafc47a into kitodo:master Oct 31, 2023
@beatrycze-volk beatrycze-volk deleted the move-tests-to-csv branch November 1, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⟳ maintenance A task to keep the code up-to-date and manageable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants