Game Jam Reworks; Component Structure overhaul - #100
Open
tm-nielsen wants to merge 75 commits into
Open
Conversation
- specified tilemap as package dependency to ensure functional samples - removed ssvep sample "manifest"
- removed monobehaviour inheritance - adjusted communication provider to host serialized writer/reader directly
- migrated trial logic to extension methods - extracted p300 trial marker helpers into extension methods - reworked implementation of non-repeating parameter of single flash context aware utility method - reintroduced stimulus presenter interface
- renamed and de-monobehavioured coroutine wrapper, stimulus presenter collection, and p300 trial conductors
- created new take on the single component megalith along with a base class, both composed of multiple helper classes that aren't unity components - de-monobehavioured training behaviours - reworked target indication
- adjusted target count to point to the latest presenter collection subset, counting only selectable presenters - ensured trial conductor has correct reference to presenter collection
- renamed ssvep trial conductor and base class, adjusting them for new design - sketched a command centre script for SSVEP
- replaced trial conductor reference used by BCI command centre to an abstract property - implemented p300 trial conductor as a hub for various p300 flashing routines used from static methods, fit for serialization - gutted p300 command centre, now using reworked trial conductor - adjusted ssvep command centre
- merged stimulus presenter collection target indicator class with p300 command centre to resolve referencing issues
- added helper class with core status tracking and cancellation logic
- reworked colour flash behaviour into a serializable class
- implemented threaded duty cycle helper class - removed time/frame cycle variants - updated references - adjusted base class and colour flash behaviour
- replaced component network setup with command centre + stimulus presenters - reworked custom stimulus presenter as a separate serializable helper class - fixed colour mask shader
| const float FieldSpacing = 4f; | ||
|
|
||
| public static KeyCode KeyCodeField(Rect position, string label, KeyCode value) | ||
| public static Key KeyCodeField(Rect position, string label, Key value) |
Collaborator
There was a problem hiding this comment.
If these are a key maybe change the function to KeyField?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redirected version 2.0's focus on component modularity to plain C# classes which can be freely and interchangeably used by monobehaviour scripts. The return of the BCI Controller Behaviour style megalith component script in a much more concise and extensible form. I hope this approach will better serve drag-and-drop users, along with those who will want to customize behaviour in depth.
I remain unsatisfied with any of the possible names I've come up with the "BCI Command Centre"/"BCI Hub"/"Composite BCI Behaviour". Suggestions welcome.