Changed preprocessing appropriately#140
Draft
danielcomaduran wants to merge 7 commits into
Draft
Conversation
| buffer_time : float, *optional* | ||
| Defines the time in seconds after an epoch for which we require EEG data to ensure that all EEG is present in that epoch. | ||
| - Default is `0.01`. | ||
| preprocessing_window : float, *optional* |
Collaborator
There was a problem hiding this comment.
Could we please change this to be a buffer around the desired epoch so that the epoch is centred in the preprocessing window?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The preprocessing in paradigm was applying different filters (i.e., low- or band-pass) depending on whether the signal to process was 2D or 3D. The reasoning for this was that I assumed that a 2D signal would be long enough to accomodate the high-pass filter.
I realized that the epochs in the P300 paradigm are processed concurrently (multiple 2D arrays) rather than simultaneously (3D array). Thus, the bandpass filter was being applied eventhough the signal was not long enough for the time constant to stabilize.
Implementation
I changed the preprocessing function to consider the time constant of any EEG signal sent regardless if it is 2D or 3D. Right now 3D is not being sent but we could later modify to process all epochs simultaneously (this would speed some things)