Windows Crash fixes#125
Closed
KWWyatt wants to merge 22 commits into
Closed
Conversation
…progress-updates Marshal project-load progress updates to the GUI thread via Qt signal/slot
…-crash Fix/project load threaded progress crash
This is needed to prevent crashing upon project loading.
Make ExperimentalDataHeaderDialog size itself relative to the available screen, cap max size, and relax widgets that could inflate minimum width/height (long file path label and preview box wrapping/height). Also add a regression test for long-path/long-line content and screen constraints.
…aheaderdialog Constrain ExperimentalDataHeaderDialog to screen bounds
Make ExperimentalDataHeaderDialog size-aware using available screen geometry, wrap long file paths and preview text, and lower preview minimum height so long content cannot force oversized minimum dimensions. Add a regression test that validates the safer wrapping behavior and screen-bounded maximum size.
…h-in-experimentaldataheaderdialog
…aheaderdialog Fix oversized ExperimentalDataHeaderDialog on experimental .txt load
Constrain header dialog child size hints so long labels and combo entries do not inflate minimum tracking size on Windows. Improve experimental header/column detection to ignore metadata comment lines while still accepting commented real headers like '# q I(q)'. Add regression coverage for metadata comment parsing and dialog size policies.
…h-in-experimentaldataheaderdialog-snudgo
…aheaderdialog-snudgo Improve experimental data header/column parsing and make header dialog UI responsive
When a commented line includes metadata and a trailing inline header fragment, extract the header-like segment instead of tokenizing metadata words as column labels. Add regression coverage for '# ... factor: 1.0 # q_(Å⁻¹) I(q)' style inputs.
…h-in-experimentaldataheaderdialog-x89ihv
…aheaderdialog-x89ihv Ignore metadata comments in experimental data parsing and improve header dialog sizing
Load numeric data through a UTF-8 text stream with errors='replace' instead of letting numpy decode the file path with platform-default codecs. This prevents charmap decode crashes from metadata bytes while preserving numeric row parsing. Add regression coverage for comments containing invalid UTF-8 bytes.
…h-in-experimentaldataheaderdialog-mncjqe
…aheaderdialog-mncjqe Improve experimental data parsing (metadata-aware) and tighten experimental-data dialog sizing
Fix experimental data dialog crash
Merge upstreabgm main
kewh5868
added a commit
that referenced
this pull request
May 26, 2026
Incorporate the safe parts of PR #125 onto the up-to-date continuation branch. Preserve comment-header column detection for metadata-heavy experimental files and constrain the experimental data header dialog so long Windows paths do not oversized-crash the UI. Co-authored-by: KWWyatt <117381914+KWWyatt@users.noreply.github.com>
Owner
Thanks for the Windows crash fixes. I pulled the safe parts of this into a fresh branch based on the current `main` baseline: `model-test-continuation`.
The incorporated commit is:
`2510447 fix(saxs): harden experimental data loading on Windows`
I kept the experimental data parsing and dialog-sizing fixes, then adjusted the implementation so pre-commit passes and so comment-header metadata is preserved even when `np.loadtxt` succeeds directly.
Validation on the cleaned branch:
- File-scoped pre-commit hooks passed.
- Focused SAXS UI/data-loading tests passed: 5 passed.
I’m going to merge via the cleaned continuation PR rather than merging this PR directly, so we can keep the history and pre-commit state clean |
kewh5868
added a commit
that referenced
this pull request
May 26, 2026
Incorporate the safe parts of PR #125 onto the up-to-date continuation branch. Preserve comment-header column detection for metadata-heavy experimental files and constrain the experimental data header dialog so long Windows paths do not oversized-crash the UI. Co-authored-by: KWWyatt <117381914+KWWyatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file handling adjustments to fix crashing at different steps.