Skip to content

Saxs plot editor#114

Merged
kewh5868 merged 7 commits into
mainfrom
saxs-plot-editor
May 7, 2026
Merged

Saxs plot editor#114
kewh5868 merged 7 commits into
mainfrom
saxs-plot-editor

Conversation

@kewh5868
Copy link
Copy Markdown
Owner

@kewh5868 kewh5868 commented May 7, 2026

Summary

  • Adds shared plotting/editor infrastructure for line plots, heatmaps, stacked histograms, and Igor-style inline labels.
  • Expands fullrmc setup with solvent-shell analysis/building, Packmol Docker linking, free-solvent allocation, structure-mode-aware Packmol setup, and constraints preview/open helpers.
  • Adds the new representativefinder CLI/UI workflow with project-backed run files, representative persistence, tests, and a performance harness.
  • Adds representative-structure SAXS component sources plus 1D/3D Born workflow integration, including the new 3D FFT Born backend/UI.
  • Updates structure viewer background-color controls.
  • Refreshes docs/navigation for representative structures, Packmol Docker, and 1D/3D Born workflows.

Validation

  • Pre-commit hooks passed for each commit.
  • git diff --check passes.
  • Generated representativefinder benchmark outputs are ignored and not committed.

Fixes #109
Fixes #110
Fixes #111

kewh5868 added 7 commits May 7, 2026 16:42
Add shared plotting helpers for Igor-style labels, editable line plots, heatmaps, and stacked histograms. Wire the heatmap editor into cluster dynamics views and vectorize bond/angle measurements used by representative-style plotting workflows.
Add Packmol Docker linking, solvent-shell analysis/building, free-solvent allocation, structure-mode aware Packmol setup, and constraints preview/open helpers. Update the fullrmc UI and tests around the integrated RMC setup flow.
Introduce the representativefinder package, console entry point, run-file workflow, Qt setup/analyzer windows, and representative persistence helpers. Add tests and a performance harness while keeping generated benchmark outputs ignored.
Add a structure-viewer background color control, preserve the selected background across redraws, and cover the behavior in the viewer tests.
Add representative-structure component sources, template metadata capabilities, persisted plot editor state, and 1D/3D Born component workflow integration. Introduce the 3D FFT Born backend/UI and expand project, prefit, electron-density, and SAXS UI tests.
Refresh the docs landing pages, install/setup guides, and user-guide navigation for representative structures, 1D/3D Born workflows, Packmol Docker linking, and updated SAXS/fullrmc terminology.
Run the docformatter hook with Python 3.12 so its untokenize dependency does not build under Python 3.14, where the package setup fails while reading AST constants.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c6f4152b79

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/saxshell/plotting/plot_editor.py
@kewh5868 kewh5868 merged commit 1521086 into main May 7, 2026
2 checks passed
@kewh5868 kewh5868 deleted the saxs-plot-editor branch May 7, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant