Feat: toggle mobile side menu#1711
Merged
MarceloRobert merged 1 commit intokernelci:mainfrom Jan 27, 2026
Merged
Conversation
MarceloRobert
added
the
Frontend
Comment on lines
32
to
41
| <DrawerContent className="bg-bg-secondary fixed inset-y-0 right-auto left-0 mt-0 h-full w-auto overflow-y-auto border-none pb-12 [&>div:first-child]:hidden"> | ||
| <DrawerHeader className="sr-only"> | ||
| <DrawerTitle> | ||
| {formatMessage({ id: 'sidemenu.descriptor' })} | ||
| </DrawerTitle> | ||
| </DrawerHeader> | ||
| <SideMenuContent onLinkClick={onClose} /> | ||
| </DrawerContent> |
Contributor
There was a problem hiding this comment.
we should add a description here or the application will be warning about it missing:
Warning: Missing Description or aria-describedby={undefined} for {DialogContent}.
Collaborator
Author
There was a problem hiding this comment.
Fixed. Thanks for noticing that
Contributor
|
also, what do you think about adding a close button with a 'X' icon in the drawer? |
Collaborator
Author
I don't think it's necessary, clicking anywhere outside of the menu will already close the drawer |
Adds a toggle in the top bar to show the side menu as a drawer Closes kernelci#1415
MarceloRobert
force-pushed
the
feat/toggle-side-menu
branch
from
02b33f6 to
fe6d5fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
How to test
Go to any page, use the Responsive Design Mode in the browser, and change the resolution of the screen. After
md, the sidebar should vanish and a toggle should appear in the TopBar.All links should still be working correctly, and the design of the pages should not break.
Examples:
Before:
After:
Mobile SideMenu (drawer):
Closes #1415