feat: Support v2 storage and send notification for each token#4
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for accepting either a legacy single push token (v1) or a JSON token-store object (v2) via the existing token parameter, enabling multi-token sends and token-age validation.
Changes:
- Introduces
TokenStore/TokenEntrywith JSON marshal/unmarshal and “string-or-JSON” parsing. - Updates
/sendhandler to parsetokeninto aTokenStore, send notifications per entry, and refactors result/status classification. - Adds unit tests for token store behavior and updates module metadata to include
go-cmp.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| token_store.go | Adds token store model + JSON/string parsing helpers. |
| token_store_test.go | Adds unit tests for token store add/find/JSON/from-string behavior. |
| sendmsg.go | Sends to multiple tokens, adds expiry checks, refactors error→result/status logic. |
| go.mod | Updates module path and adds github.com/google/go-cmp dependency. |
| buildinfo.go | Adjusts build info formatting for goreleaser builds (short commit/date). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kenstir
changed the title
kenstir
changed the title
kenstir
changed the title
kenstir
changed the title
because EG corrupts user settings that contain double quotes.
This test uses a known good encoding to ensure that the encoder/decoder used is compatible with other platform implementations.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add support for passing multiple time-stamped push notification tokens in
the
tokenparam as a base64url-encoded JSON object.Details
time-stamped push notification (PN) tokens in FIFO order
JSON TS object (v2)