Skip to content

Fix for "tainted canvas"#60

Open
homerjam wants to merge 3 commits into
kennethcachia:masterfrom
homerjam:fix-tainted-canvas
Open

Fix for "tainted canvas"#60
homerjam wants to merge 3 commits into
kennethcachia:masterfrom
homerjam:fix-tainted-canvas

Conversation

@homerjam

Copy link
Copy Markdown

This fixes this security complaint for background images:

Failed to execute 'getImageData' on 'CanvasRenderingContext2D': The canvas has been tainted by cross-origin data.

https://developer.mozilla.org/en-US/docs/Web/HTML/CORS_enabled_image

@homerjam homerjam mentioned this pull request Mar 26, 2015
@bradcerasani

Copy link
Copy Markdown

👍

@homerjam Probably want to run grunt uglify on your branch to generate a minified version with the fix as well

@homerjam

Copy link
Copy Markdown
Author

Sure, there you go. Thanks

@madeleineostoja

Copy link
Copy Markdown

Any progress on this being merged into master?

@lostinpatterns

Copy link
Copy Markdown

This fixed the issue I was having with images hosted at S3.

@janein janein left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works perfectly fine.

@janein

janein commented Sep 27, 2016

Copy link
Copy Markdown

would love to see this merged!

@rodolfogordo10

Copy link
Copy Markdown

Last merge was 2014 😭

@justrealmilk

Copy link
Copy Markdown

Where's the give all my money to button

@Jiab77

Jiab77 commented Jun 19, 2018

Copy link
Copy Markdown

@homerjam Dude! you helped me so much with this PR 👍
Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants