Ignore brightness of pixels outside the viewport#119
Open
DanActions wants to merge 2 commits into
Open
Conversation
d403521 to
6338e82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57 by ignoring pixels outside of the viewport when calculating brightness.
I think the issue is in
calculatePixelBrightness(). The following lines get the dimensions of the target image and fetch those pixels from the canvas:The function then loops through
datapixel-by-pixel to calculate the average brightness.The problem is that if part of the bounding rectangle is outside the viewport,
getImageDatawill return rgba(0,0,0,0) for those pixels. The formula thatcalculatePixelBrightness()uses to calculate average brightness doesn't consider the alpha value, causing it to see these pixels as black, thus skewing the calculated brightness to be much darker than the visible image.The pull request attempts to fix this by trimming off the parts of the bounding rectangle that are outside the viewport before calling
getImageData.