feat(ripple): forward memo to device for THORChain XRP swap routing#42
Open
BitHighlander wants to merge 1 commit into
Open
feat(ripple): forward memo to device for THORChain XRP swap routing#42BitHighlander wants to merge 1 commit into
BitHighlander wants to merge 1 commit into
Conversation
Forward tx.value.memo to the RippleSignTx protobuf message so the firmware can include it in the XRPL Memos array of the signed transaction.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tx.value.memotoRippleSignTxprotobuf when signing XRP transactionsProblem
The vault's XRP tx builder correctly parses THORChain swap memos and stores them in
tx.value.memo, butrippleSignTx()in hdwallet-keepkey never calledsetMemo()on the protobuf message. The memo was dropped before reaching the device, so the firmware never included it in the signed XRPL transaction.Change
One line in
packages/hdwallet-keepkey/src/ripple.ts:Dependencies
BitHighlander/device-protocol feat/xrp-memo-thorchain—RippleSignTxproto must have field 7 (memo)BitHighlander/keepkey-firmware feat/xrp-memo-thorchain— firmware must serialize the memo into XRPL Memos arrayTest plan
=:ETH.ETH:0x...appears in device confirmation and is serialized into tx