fix(zcash): unbreak master CI — prettier wrap + jest/no-conditional-expect#41
Open
BitHighlander wants to merge 1 commit into
Open
fix(zcash): unbreak master CI — prettier wrap + jest/no-conditional-expect#41BitHighlander wants to merge 1 commit into
BitHighlander wants to merge 1 commit into
Conversation
…xpect CI on master has been red since d83a65c (fix(zcash): stream transparent shield inputs). Two issue classes: - 4× prettier/prettier — long template literals on a single line; auto-fixed by `eslint --fix` (line-wrap inside the template). - 3× jest/no-conditional-expect in zcash.test.ts — the mock implements a protocol state-machine and asserts per-step that the host sent the right message at the right time. Refactoring to top-level assertions would reshape the test; keep the per-step behavior with targeted disable comments. No behavior change. Confirmed `yarn lint` is clean.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Master CI has been red since d83a65c (
fix(zcash): stream transparent shield inputs). Two issue classes:zcash.ts— long template literals on a single line; auto-fixed byeslint --fix(line-wrap inside template).zcash.test.ts— the mock implements a protocol state-machine and asserts per-step that the host sent the right message at the right time. Refactoring to top-level assertions would reshape the test; preserved per-step semantics with targeted disable comments.No behavior change. Confirmed
yarn lintclean locally.Test plan
zcash.test.tscases still cover the same behavior