fix: register Osmosis + Ethereum in transport typeRegistry#36
Closed
BitHighlander wants to merge 1 commit into
Closed
fix: register Osmosis + Ethereum in transport typeRegistry#36BitHighlander wants to merge 1 commit into
BitHighlander wants to merge 1 commit into
Conversation
…gistry The transport's fromMessageBuffer() looks up response message types in messageTypeRegistry to deserialize device responses. Osmosis and Ethereum protobuf modules were imported by their respective chain files but never added to the AllMessages array in typeRegistry.ts. When the device responded to OsmosisGetAddress (type 1100), the transport couldn't find a constructor for type 1101 (OsmosisAddress), so it fabricated a fake Failure with "Unknown message type received" — making it look like a firmware error when the firmware responded correctly. Same issue affected Ethereum message types that aren't in the base Messages module (e.g. EthereumTxMetadata responses). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fromMessageBuffer()fabricated fakeFailure("Unknown message type received")for Osmosis responses becauseOsmosisMessageswasn't in theAllMessagesarray intypeRegistry.tsOsmosisGetAddress(type 1100) but the transport couldn't deserialize theOsmosisAddressresponse (type 1101) — no constructor registeredEthereumMessages(needed for EthereumTxMetadata responses in clear-signing flow)Test plan
wallet.osmosisGetAddress()returns a validosmo1...address on firmware 7.10.0+wallet.cosmosGetAddress()still works (regression check)