fix: add request parameter to webhook_challenge for Netdata#6121
Merged
shahargl merged 1 commit intokeephq:mainfrom Mar 22, 2026
Merged
fix: add request parameter to webhook_challenge for Netdata#6121shahargl merged 1 commit intokeephq:mainfrom
shahargl merged 1 commit intokeephq:mainfrom
Conversation
) The webhook_challenge function was calling Request.query_params.get() on the Starlette Request *class* instead of a request *instance*, causing AttributeError on every Netdata webhook challenge request. Fix: add 'request: Request' parameter and use 'request.query_params' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@lalalic is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
👏 Fantastic work @lalalic! Your very first PR to keep has been merged! 🎉🥳 You've just taken your first step into open-source, and we couldn't be happier to have you onboard. 🙌 For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! 👩💻👨💻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6116
The
webhook_challengeendpoint for Netdata was callingRequest.query_params.get()on the StarletteRequestclass instead of a request instance. Sincequery_paramsis an instance property, this raisesAttributeErroron every request — making the Netdata webhook challenge completely broken.Root Cause
Fix
Changes
request: Requestparameter towebhook_challengeRequest.query_params→request.query_params2-line fix. No tests needed — the bug is a straightforward Python instance vs class error.