Fix PHP 8.1+ deprecation: Handle null values in str_replace()#59
Open
baullmear wants to merge 6 commits intokeboola:masterfrom
Open
Fix PHP 8.1+ deprecation: Handle null values in str_replace()#59baullmear wants to merge 6 commits intokeboola:masterfrom
baullmear wants to merge 6 commits intokeboola:masterfrom
Conversation
- Add null coalescing operator to handle null column values - Prevents 'Passing null to parameter' deprecation warning in PHP 8.1+ - Maintains backward compatibility with existing behavior (null becomes empty string) - Fixes issue where writeRow() accepts null values but str_replace() doesn't
Author
|
Please careful, vibecoded PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes PHP 8.1+ deprecation warnings when writing CSV rows with null values.
Problem
rowToStr()accepts null values (line 348:is_null($column)check)str_replace()which doesn't accept null in PHP 8.1+Deprecated: Passing null to parameter #3 ($subject) of type array|stringSolution
$column ?? ''Testing
✅ Tested with real-world production data containing null values