Skip to content

Harden CI dependency installs against lifecycle-script execution #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karoltheguy merged 2 commits into from
Aug 3, 2026
Merged

Harden CI dependency installs against lifecycle-script execution #304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48f28ed
Harden CI dependency installs against lifecycle-script execution
karoltheguy Aug 3, 2026
4d9dbac
Merge branch 'main' into fix/ci-supply-chain-hardening
karoltheguy Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,12 @@

- name: Install Node.js dependencies
if: ${{ matrix.needs_node && steps.node-cache.outputs.cache-hit != 'true' }}
run: npm ci
# --ignore-scripts keeps lifecycle scripts in the dependency tree from
# running. copy-assets is our own postinstall step and is what vendors
# static/vendor/, so it has to be invoked explicitly instead.
run: |
npm ci --ignore-scripts
npm run copy-assets

- name: Set up Python
uses: actions/setup-python@v7
Expand All @@ -148,8 +153,8 @@
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -r requirements.txt
pip install -r requirements-test.txt
pip install --only-binary :all: -r requirements.txt

Check warning on line 156 in .github/workflows/tests.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Using dependencies without locking resolved versions is security-sensitive. 


See more on https://sonarcloud.io/project/issues?id=karoltheguy_QuadletManager&issues=AZ_JDrg-OM_HAlRrYhyQ&open=AZ_JDrg-OM_HAlRrYhyQ&pullRequest=304
pip install --only-binary :all: -r requirements-test.txt

Check warning on line 157 in .github/workflows/tests.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Using dependencies without locking resolved versions is security-sensitive. 


See more on https://sonarcloud.io/project/issues?id=karoltheguy_QuadletManager&issues=AZ_JDrg-OM_HAlRrYhyR&open=AZ_JDrg-OM_HAlRrYhyR&pullRequest=304

- name: Cache Playwright browsers
if: ${{ matrix.needs_playwright }}
Expand Down Expand Up @@ -577,7 +582,12 @@

- name: Install Node.js dependencies
if: ${{ matrix.needs_node && steps.node-cache.outputs.cache-hit != 'true' }}
run: npm ci
# --ignore-scripts keeps lifecycle scripts in the dependency tree from
# running. copy-assets is our own postinstall step and is what vendors
# static/vendor/, so it has to be invoked explicitly instead.
run: |
npm ci --ignore-scripts
npm run copy-assets

- name: Set up Python
uses: actions/setup-python@v7
Expand All @@ -591,8 +601,8 @@
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -r requirements.txt
pip install -r requirements-test.txt
pip install --only-binary :all: -r requirements.txt

Check warning on line 604 in .github/workflows/tests.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Using dependencies without locking resolved versions is security-sensitive. 


See more on https://sonarcloud.io/project/issues?id=karoltheguy_QuadletManager&issues=AZ_JDrg-OM_HAlRrYhyS&open=AZ_JDrg-OM_HAlRrYhyS&pullRequest=304
pip install --only-binary :all: -r requirements-test.txt

Check warning on line 605 in .github/workflows/tests.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Using dependencies without locking resolved versions is security-sensitive. 


See more on https://sonarcloud.io/project/issues?id=karoltheguy_QuadletManager&issues=AZ_JDrg-OM_HAlRrYhyT&open=AZ_JDrg-OM_HAlRrYhyT&pullRequest=304

- name: Cache Playwright browsers
if: ${{ matrix.needs_playwright }}
Expand Down
Loading